Re: [PATCH] tune2fs: fix uninitialized variable in remove_journal_device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 01, 2014 at 08:38:30AM +0200, Andreas Dilger wrote:
> >    /* Write back the journal superblock */
> > -    if ((retval = io_channel_write_blk64(jfs->io, start,
> > -        -SUPERBLOCK_SIZE, buf))) {
> > +    if ((retval = io_channel_write_blk64(jfs->io,
> > +                ext2fs_journal_sb_start(fs->blocksize),
> > +                -SUPERBLOCK_SIZE, buf))) {
> 
> Better to also remove assignment in conditional check. 

Good point, done.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux