Hi Ted, On 07/31/2014 11:32 PM, Theodore Ts'o wrote: > On Tue, Jul 29, 2014 at 09:58:19AM -0400, Theodore Ts'o wrote: >> On Wed, Jul 23, 2014 at 05:47:41PM +0800, Xiaoguang Wang wrote: >>> In ext4_mb_normalize_request(), if ac_g_ex.fe_logical is adjacent to the closest logical >>> allocated block to the left or (ac_g_ex.fe_logical+len) adjacent to the closest logical >>> allocated block to the right, we'll attach EXT4_MB_HINT_TRY_GOAL flag taking the physical >>> block (ext4_allocation_request.lleft+1) or (ext4_allocation_request.pright-len) as a goal, >>> and put this information in ext4_allocation_context.ac_f_ex. >>> >>> But look at the ext4_mb_find_by_goal(), indeed it use ac_g_ex to look up, so this is wrong, >>> we should save goal group and offset in struct ext4_allocation_context.ac_g_ex. >>> >>> Signed-off-by: Xiaoguang Wang <wangxg.fnst@xxxxxxxxxxxxxx> >> >> Nice catch! >> >> Thanks, applied. > > I've had to drop this patch, as it is causing xfstests failures for > generic/074. Before sending this patch, I didn't run the whole xfstests for ext4, sorry. Next time, if I'll send some new patches, I'll run the xfstests for ext4. > > I'm not sure why, and right now I don't have time to investigate. If > someone who has time and experience wading into fs/ext4/mballoc.c, it > would be great if someone could take a closer look. I'll investigate it and have full tests, thanks! Regards, Xiaoguang Wang > > - Ted > . > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
