On Sat, Jul 26, 2014 at 05:09:53PM -0400, Theodore Ts'o wrote: > On Fri, Jul 25, 2014 at 05:34:28PM -0700, Darrick J. Wong wrote: > > Make the "EA block passes checks but fails checksum" message less > > strange, and make the other checksum error messages actually print a > > period at the end of the sentence. > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Applied (with some slight adjustments since I haven't pulled in the > previous patch pending discussion). I note that there was no need to > adjust any of the expected messages in the e2fsprogs regression tests. > > This indicates that we don't have enough (well, any) regression tests > covering the metadata checksum feature. :-( That's what the metadata checksum test script was supposed to be about. I'm not sure if it's actually getting through to anyone -- Google doesn't seem to have any links to it. It's a big script that takes a bunch of mke2fs flags and runs through a bunch of corruption detection tests to see if the running kernel and e2fsck notice. The nice thing about the script is that it can cycle through a lot of different features, block sizes, etc. pretty quickly, which seems difficult to do with the plain 'make check' tests. I could look into turning them into a bunch of ext4 xfstests. --D > > - Ted > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
