Re: [PATCH 06/18] dumpe2fs: add switch to disable checksum verification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 25, 2014 at 05:34:16PM -0700, Darrick J. Wong wrote:
> Add a -n switch to turn off checksum verification.

Instead of adding a -n flag, I wonder if the better thing to do is if
the various functions that might return a checksum error error out, we
print a warning message indicating checksum failure occured, and then
retry with EXT2_FLAG_IGNORE_CSUM_ERRORS.  That is, either retry the
ext2fs_open with the IGNORE_CSUM_ERRORS, or if the file system is
already open, or in EXT2_FLAG_IGNORE_CSUM_ERRORS into fs->flags and
then retry the ext2fs_read_bitmaps() or whatever.

What do you think?

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux