Re: [PATCH 20/24] e2fsck: pass2 should not process directory blocks that are impossibly large

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 18, 2014 at 03:54:46PM -0700, Darrick J. Wong wrote:
> Currently, directories cannot be fallocated, which means that the only
> way they get bigger is for the kernel to append blocks one by one.
> Therefore, if we encounter a logical block offset that is too big, we
> needn't bother adding it to the dblist for pass2 processing, because
> it's unlikely to contain a valid directory block.  The code that
> handles extent based directories also does not add toobig blocks to
> the dblist.
> 
> Note that we can easily cause e2fsck to fail with ENOMEM if we start
> feeding it really large logical block offsets, as the dblist
> implementation will try to realloc() an array big enough to hold it.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux