On Tue, Jul 22, 2014 at 12:43:56PM -0400, Theodore Ts'o wrote: > On Sat, Jul 19, 2014 at 10:49:35AM -0600, Andreas Dilger wrote: > > Wouldn't it be better to decode and print the whole symlink from the > > inline data? Depending on the use of debugfs, printing only the > > first 60 bytes may cause people/scripts to think the link is > > corrupted. > > I agree in principle, although for now, this fixes a bug, so I'll > apply it. Humans shouldn't get too confused, since we now do print > the extended attributes: Nah, ignore/revert it, I'll have a better patch out in a few minutes. > debugfs: stat symlinkfile > Inode: 131075 Type: symlink Mode: 0777 Flags: 0x10000000 > Generation: 3080286240 Version: 0x00000000:00000001 > User: 0 Group: 0 Size: 62 > File ACL: 0 Directory ACL: 0 > Links: 1 Blockcount: 0 > Fragment: Address: 0 Number: 0 Size: 0 > ctime: 0x53ce9340:c78386a4 -- Tue Jul 22 16:37:20 2014 > atime: 0x53ce9346:bd2d7348 -- Tue Jul 22 16:37:26 2014 > mtime: 0x53ce9340:c78386a4 -- Tue Jul 22 16:37:20 2014 > crtime: 0x53ce9340:c78386a4 -- Tue Jul 22 16:37:20 2014 > Size of extra inode fields: 28 > Extended attributes: > system.data = "89" (2) > Fast_link_dest: "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz01234567" > > > But I would agree it owuld be better if we displayed the symlink > target completely. Yes, I'll do that. --D > > - Ted > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
