Re: [PATCH 09/24] e2fsck: clear i_block if there are too many bad block mappings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 18, 2014 at 03:53:21PM -0700, Darrick J. Wong wrote:
> If there are too many bad block mappings in a file and the user says
> to zap it, erase i_block before clearing the inode.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Why is this necessary?  E2fsck will clear i_links_count and set dtime,
so the contents of i_block shouldn't matter, yes?

						- Ted

> 
> diff --git a/e2fsck/pass1.c b/e2fsck/pass1.c
> index b696d02..18980f1 100644
> --- a/e2fsck/pass1.c
> +++ b/e2fsck/pass1.c
> @@ -2329,6 +2329,7 @@ static void check_blocks(e2fsck_t ctx, struct problem_context *pctx,
>  	}
>  
>  	if (pb.clear) {
> +		memset(inode->i_block, 0, sizeof(inode->i_block));
>  		e2fsck_clear_inode(ctx, ino, inode, E2F_FLAG_RESTART,
>  				   "check_blocks");
>  		return;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux