On Fri, Jul 18, 2014 at 03:53:11PM -0700, Darrick J. Wong wrote: > When we're about to iterate the blocks of a block-map file, we need to > write the inode out to disk if it's dirty because block_iterate3() > will re-read the inode from disk. (In practice this won't happen > because nothing dirties block-mapped inodes before the iterate call, > but we can program defensively). > > More importantly, we need to re-read the inode after the iterate() > operation because it's possible that mappings were changed (or erased) > during the iteration. If we then dirty or clear the inode, we'll > mistakenly write the old inode values back out to disk! > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> Thanks, applied. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html