Coverity (re-)spotted this; it was triaged as a false positive, but it seems pretty clear that the bh (which was just checked) isn't currently freed before the function exits. Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> --- diff --git a/e2fsck/recovery.c b/e2fsck/recovery.c index 54579c2..66d02b2 100644 --- a/e2fsck/recovery.c +++ b/e2fsck/recovery.c @@ -523,6 +523,7 @@ static int do_one_pass(journal_t *journal, !jbd2_descr_block_csum_verify(journal, bh->b_data)) { err = -EIO; + brelse(bh); goto failed; } -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html