On Mon, 14 Jul 2014, Theodore Ts'o wrote: > Date: Mon, 14 Jul 2014 07:56:23 -0400 > From: Theodore Ts'o <tytso@xxxxxxx> > To: Lukáš Czerner <lczerner@xxxxxxxxxx> > Cc: Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH -v2] ext4: rearrange initialization to fix EXT4FS_DEBUG > > On Mon, Jul 14, 2014 at 10:04:47AM +0200, Lukáš Czerner wrote: > > > + block = ext4_count_free_clusters(sb); > > > + ext4_free_blocks_count_set(sbi->s_es, block); > > > > > > This does not seem right. block is in cluster units so we need to > > convert. > > > > ext4_free_blocks_count_set(sbi->s_es, EXT4_C2B(sbi, blocks)); > > > > Otherwise it looks good to me. > > Thanks, for catching this! II've fixed up the patch on the ext4 git tree. > > - Ted In that case, you can add. Reviewed-by: Lukas Czerner <lczerner@xxxxxxxxxx> Thanks! -Lukas
