On Thu, Jun 12, 2014 at 8:30 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: > On Fri, Jun 13, 2014 at 01:15:38PM +1000, Dave Chinner wrote: >> Indeed, mixing -o discard and SFITRIM is a recipe for >> confusion and leakage - "but I used secure trim on the device!" - >> and so all discards either have to be secure or not. The idea was to keep on not using -o discard. And move from FITRIM to SFITRIM. > Oh, and while I think of it secure discard at the filesystem level > isn't even a guarantee that you'll get rid of all stale references > to a sector - if the filesystem has freed and then re-allocated a > block without having gone through a discard cycle on that block, > then the underlying device may have old copies of the block that it > hasn't garbage collected and SFITRIM won't clean those up because it > won't ask to trim in-use blocks.... Arg. So, if understand this correctly, if the eMMC chip won't get a secure discard/trim of a block that gets reassigned to the FS, then data duplicates within the eMMC related to that block are not cleared, and the next SFITRIM won't even reach that block or the duplicates as the FS says they are in use. > So, really, secure trim from a filesystem perspective can leak stale > data at multiple layers.... .. back to the drawing board to evaluate how much leakage we can live with or maybe go down a path of fibmap + some secure form of erase (eMMC level secure trim). Thanks for now. -- -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
