On Tue, 20 May 2014, Nikola Ciprich wrote: > Date: Tue, 20 May 2014 11:47:41 +0200 > From: Nikola Ciprich <nikola.ciprich@xxxxxxxxxxx> > To: Lukáš Czerner <lczerner@xxxxxxxxxx> > Cc: Theodore Ts'o <tytso@xxxxxxx>, Darrick J. Wong <darrick.wong@xxxxxxxxxx>, > linux-ext4@xxxxxxxxxxxxxxx, Nikola Ciprich <nikola.ciprich@xxxxxxxxxxx> > Subject: Re: [PATCH] ext4: add sysfs entry showing whether the fs contains > errors > > Hello Lukáš, > > just wanted to ask about the status of this patch.. it didn't make it > to git yet, did it? Do you plan to make some changes to it? I'm eager > to test it ;-) No it did not and it would not given that there was not a merge window since then. I've been distracted by other work, but I'll put you in cc when I have a new patch - yes I plan to change the format of the output to be more compliant with sysfs rules. -Lukas > > cheers > > nik > > > On Wed, May 07, 2014 at 10:44:34AM +0200, Lukáš Czerner wrote: > > On Tue, 6 May 2014, Theodore Ts'o wrote: > > > > > Date: Tue, 6 May 2014 15:23:26 -0400 > > > From: Theodore Ts'o <tytso@xxxxxxx> > > > To: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > Cc: Lukas Czerner <lczerner@xxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, > > > nikola.ciprich@xxxxxxxxxxx > > > Subject: Re: [PATCH] ext4: add sysfs entry showing whether the fs contains > > > errors > > > > > > On Tue, May 06, 2014 at 10:43:01AM -0700, Darrick J. Wong wrote: > > > > > > > > Minor complaint: "contains" makes me think that cat'ing that file will return > > > > either 0 or 1, not a string of error text. Perhaps we could shorten it to > > > > /sys/fs/ext4/sda/errors ? > > > > > > What I'd suggest doing is simply calling it errors_count, and > > > returning s_error_count. While we're at it, we could also return > > > s_first_error_time and s_last_error_time as well, since I imagine > > > those would could be quite useful for someone trying to create a > > > system health monitoring daemon. > > > > > > Cheers, > > > > > > - Ted > > > > Right now I am using the same function which prints this information > > to the log. So I am going to use simpler output for the sysfs. > > > > <error count> <first time> <function>:<line> <last time> <function>:<line> > > > > That should be easy to parse. I think that just calling it errors is > > good enough. > > > > Thanks! > > -Lukas > > > >
