Re: [PATCH 4/5] ext4: don't crash when validating block bitmap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 12, 2014 at 10:24:57AM -0400, Theodore Ts'o wrote:
> On Thu, May 01, 2014 at 04:17:47PM -0700, Darrick J. Wong wrote:
> > If EXT4FS_DEBUG is defined, ext4_validate_block_bitmap is called via
> > ext4_count_free_clusters before sb->s_group_info is set up.  When this
> > happens, the kernel crashes because group info hasn't been loaded.
> > Forego marking the group corrupt for now; not setting BH_Verified
> > means we'll revisit the bitmap if something went wrong.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> This shouldn't be necessary that we have this in the ext4 tree, right?

Err... right, you can drop this patch of mine.

--D

> 
> commit 007649375f6af242d5b1df2c15996949714303ba
> Author: Azat Khuzhin <a3at.mail@xxxxxxxxx>
> Date:   Mon Apr 7 10:54:20 2014 -0400
> 
>     ext4: initialize multi-block allocator before checking block descriptors
>     
>     With EXT4FS_DEBUG ext4_count_free_clusters() will call
>     ext4_read_block_bitmap() without s_group_info initialized, so we need to
>     initialize multi-block allocator before.
>     
>     ...
> 
> 						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux