Applied, with Lukáš's nits addressed. One comment: > > > @@ -612,7 +616,7 @@ static errcode_t __populate_fs(ext2_filsys fs, ext2_ino_t parent_ino, > > > if (p == NULL) { > > > com_err(name, errno, > > > _("Not enough memory")); > > > - return errno; > > > + goto out; > > > > same here. > > Yes. Thank you for spotting these. The original code was buggy here, since realloc() doesn't set errno. I've added: retval = EXT2_ET_NO_MEMORY; before the "goto out" line. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html