On Thu, Apr 17, 2014 at 9:52 AM, jon ernst <jonernst07@xxxxxxxxx> wrote: > fallocate_zero_range, check if inode is regular file. > > Signed-off-by: Jon Ernst <jonernst07@xxxxxxxxx> > --- > fs/ext4/extents.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index 1bb3e4b..756a3b9 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c > @@ -4742,6 +4742,8 @@ static long ext4_zero_range(struct file *file, > loff_t offset, > > trace_ext4_zero_range(inode, offset, len, mode); > > + if (!S_ISREG(inode->i_mode)) > + return -EOPNOTSUPP; IMO returning -EINVAL is better suited in this situation. And the same error value has to be updated for collapse_range too. (as mentioned by Michael in other mail thread regarding manpage patch of collapse range) > /* > * Write out all dirty pages to avoid race conditions > * Then release them. > -- > 1.8.1.2 > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
