> > }
> >
> > + if (EXT4_SB(inode->i_sb)->s_cluster_ratio > 1) {
> > + ret = -EOPNOTSUPP;
> > + goto out_mutex;
> > + }
> > +
>
> I do not think we need to hold mutex for this. You can move it to
> the beginning of the function preferably right after S_ISREG check.
>
> Otherwise it looks ok, but it would be better if we could fix it :)
Okay, Thanks for review!
>
> Reviewed-by: Lukas Czerner <lczerner@xxxxxxxxxx>
>
> > truncate_pagecache_range(inode, ioffset, -1);
> >
> > /* Wait for existing dio to complete */
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
