On 2014/4/8 13:46, Christoph Hellwig wrote: > On Tue, Apr 08, 2014 at 10:02:50AM +0800, ZhangZhen wrote: >> Before setting the acl, call posix_acl_valid() to check if it is >> valid or not. > > Why? posix_acl_xattr_set already does that for you, and it's the only > way to feed in an ACL from userspace. > > > Hi Hellwig, You are right, this patch is useless. I'm sorry for this spam mail. But btrfs_set_acl checks the validity of the ACL too. Should we delete it? Another choice is we can check the validity in every fs tree, and delete the check from posix_acl_xattr_set. How should we do? Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
