Re: [PATCH] fs/ext4/extents_status.c: fix 64-bit number truncation bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/07/2014 12:14 PM, Theodore Ts'o wrote:
> On Sun, Apr 06, 2014 at 03:39:09PM +0200, Geert Uytterhoeven wrote:
>> On Mon, Mar 31, 2014 at 3:16 PM, Chen Gang <gang.chen.5i5j@xxxxxxxxx> wrote:
>>> '0x7FDEADBEEF' will be truncated to 32-bit number under unicore32. Need
>>> append 'ULL' for it.
>>>
>>> The related warning (with allmodconfig under unicore32):
>>>
>>>     CC [M]  fs/ext4/extents_status.o
>>>   fs/ext4/extents_status.c: In function ‘__es_remove_extent’:
>>>   fs/ext4/extents_status.c:813: warning: integer constant is too large for ‘long’ type
>>
>> Thanks! This is failing on all 32-bit architectures.
> 
> Yes, it's harmless (since we don't actually check the value anywhere;
> this is just so humans could easily spot bugs when debugging), but
> I'll make sure this gets queued for 3.15 fixes in the ext4 tree.
> 
> Thanks!!
> 

OK, thanks. Also thank for the related Application usage information.

Next, in open source, welcome to provide related Application usage
information, when review my patches. It will be useful to evaluate my
contributions (at least, it can let myself more clearer).

It will also be useful to me (in fact, for most of my patches, I am not
familiar with the related Application's usage case).


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux