On Fri, Apr 4, 2014 at 3:44 PM, Jan Kara <jack@xxxxxxx> wrote: > On Thu 03-04-14 23:53:08, Ted Tso wrote: >> On Thu, Apr 03, 2014 at 12:39:42PM -0700, Linus Torvalds wrote: >> > Btw, since I'm planning on getting to the filesystem pulls later today >> > (or perhaps tomorrow), I wanted to check: are you ok with the ext4 >> > parts of the cross-rename patches from Miklos? >> > >> > They are currently at >> > >> > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git cross-rename >> > >> > in case you want to refresh your memory. >> >> I've pulled in the cross-rename branch to my test branch and run a set >> of tests, and it passes. Unfortunately I don't believe Miklos >> contributed tests for renameat(2) to xfstests, so we don't have any >> on-point testing of renameat() and cross-rename, but it's at least not >> triggering any failures on the existing tests. > Actually Miklos has contributed xfstests tests. I'm not sure if they were > merged but I've seen them flying by. Yes: http://marc.info/?l=linux-kernel&m=139523745403081&w=2 The following cases are tested: 1) plain rename (flags = 0) 2) cross rename 3) noreplace rename For each the following are tested: a) same directory rename b) cross directory rename And all combinations of source and dest being: - negative - regular file - symlink - empty dir - nonempty dir After the operation the file type of both source and dest are checked (or the error value returned). Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
