2014/04/01 14:15:16, Theodore Ts'o wrote:
> We should be returning an error when we pass in an lblk >=
> EXT4_MAX_BLOCKS in ext4_map_blocks(), long before we even get to
> ext4_ext_put_gap_in_cache(). And if we fix it there, we may catch
> other cases which might lead to the BUG_ON() firing.
Agree. I'll send the fixed patch latter.
> Did you check whether the same bug can be triggered via FIEMAP?
FIEMAP ioctl is safe because ext4_fiemap() has the following check.
last_blk = (start + len - 1) >> inode->i_sb->s_blocksize_bits;
if (last_blk >= EXT_MAX_BLOCKS)
last_blk = EXT_MAX_BLOCKS-1;
AFAIK, FIBMAP is only the way to pass the block number specified by a user to
ext4_map_blocks().
Regards,
Kazuya Mio
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
