Re: [PATCH 17/49] libext2fs: fix 64bit overflow in ext2fs_block_alloc_stats_range

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 10, 2014 at 11:55:46PM -0700, Darrick J. Wong wrote:
> In ext2fs_block_alloc_stats_range(), the quantity "-inuse * n" is
> calculated as a signed 32-bit quantity.  Unfortunately, gcc (4.6.3 on
> Ubuntu 12.04) doesn't sign-extend this quantity to fill the blk64_t
> parameter that ext2fs_free_blocks_count_add() wants, so the end result
> is that the superblock gets a ridiculously huge free block count.
> 
> Changing the declaration of 'n' to blk64_t seems to fix this.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux