On Tue, Mar 11, 2014 at 11:45:39PM -0400, Theodore Ts'o wrote: > On Tue, Mar 11, 2014 at 11:41:10PM -0400, Theodore Ts'o wrote: > > We had several functions that were not returning zero on success. Fix > > this. > > > > Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx> > > One additional gcc -Wall nit which I have not yet fixed: > > create_inode.c is using ext2fs_inline_data_init() which is currently a > private function defined in ext2fsP.h. > > We either need to make this a publically exported interface (in which > case we have to guarantee that it is stable), or we need to find > another way to make the right thing happen here. > > Darrick, Robert, do you have any thoughts or suggestions? I fixed that up in the cppcheck cleanups patch by moving those declarations to ext2fs.h. Maybe I should have shoved the patch closer to the head. --D > > - Ted > > P.S. My bad for not doing a gcc -Wall run on the patches before > accepting them. And in the future, I'd appreciate it if people who > are preparing patches do a "make gcc-wall" and make sure you're not > making things worse. There are plenty of bugs that can be turned up > this way. > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
