On Thu, 6 Mar 2014, Christoph Hellwig wrote: > Date: Thu, 6 Mar 2014 09:44:20 -0800 > From: Christoph Hellwig <hch@xxxxxxxxxxxxx> > To: Lukas Czerner <lczerner@xxxxxxxxxx> > Cc: linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx > Subject: Re: [PATCH v2 1/8] xfstests: Create single function for testing > xfs_io commands > > On Wed, Mar 05, 2014 at 04:51:32PM +0100, Lukas Czerner wrote: > > Currently there are several function testing various xfs_io commands. > > This commit creates _require_xfs_io_command() to test any xfs_command. > > Looks good. Do you plan to keep the wrappers around > _require_xfs_io_command in the long run or just for a transitional > period? I didn't really want to go back and change all the callers, but it can be done eventually. I do not have any strong opinions either way. > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks! -Lukas > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html