> +#ifdef HAVE_LINUX_FIEMAP_H > +struct print_flags fiemap_flags[] = { > + { FIEMAP_FLAG_SYNC, "SYNC"}, > + { FIEMAP_FLAG_XATTR, "XATTR"}, > + { -1, NULL} > +}; Can be static. > + > +#define translate_fiemap_flags(mode) \ > + ({translate_flags(mode, "|", fiemap_flags);}) > +#endif Any reason to not have these two inside fiemap_f? Otherwise: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html