On Thu, 27 Feb 2014, ZhangZhen wrote: > Date: Thu, 27 Feb 2014 17:26:09 +0800 > From: ZhangZhen <zhenzhang.zhang@xxxxxxxxxx> > To: jack@xxxxxxx, tytso@xxxxxxx > Cc: linux-ext4@xxxxxxxxxxxxxxx > Subject: [PATCH] ext3/4: remove some unnecessary comments > > The comments in the code are unnecessary, because every generic_file_write() > is replaced by generic_file_aio_write(). I am sorry I do not understand. Is it unnecessary or wrong ? If it's wrong why it is wrong ? Your description suggests that this should be changed to mention generic_file_aio_write() rather than generic_file_write(). Thanks! -Lukas > > Signed-off-by: Zhang Zhen <zhenzhang.zhang@xxxxxxxxxx> > --- > fs/ext3/inode.c | 4 ---- > fs/ext4/inode.c | 4 ---- > 2 files changed, 8 deletions(-) > > diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c > index 384b6eb..e08c2eb 100644 > --- a/fs/ext3/inode.c > +++ b/fs/ext3/inode.c > @@ -3212,10 +3212,6 @@ out_brelse: > * > * We are called from a few places: > * > - * - Within generic_file_write() for O_SYNC files. > - * Here, there will be no transaction running. We wait for any running > - * transaction to commit. > - * > * - Within sys_sync(), kupdate and such. > * We wait on commit, if tol to. > * > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 6e39895..5ef32f0 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -4399,10 +4399,6 @@ out_brelse: > * > * We are called from a few places: > * > - * - Within generic_file_write() for O_SYNC files. > - * Here, there will be no transaction running. We wait for any running > - * transaction to commit. > - * > * - Within sys_sync(), kupdate and such. > * We wait on commit, if tol to. > * > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
