On Tue, Feb 25, 2014 at 08:15:28PM +0100, Lukas Czerner wrote: > This is copy of xfs/242. However it's better to make it file system > specific because the range can be zeroes either directly by writing > zeroes, or converting to unwritten extent, so the actual result might > differ from file system to file system. You could say the same thing about preallocation using unwritten extents. Yet, funnily enough, we have generic tests for them because all filesystems currently use unwritten extents for preallocation and behave identically.... This test is no different - all filesystems currently use unwritten extents, and so this test should be generic because all existing filesystems *should* behave the same. When we get a filesystem that zeros rather uses unwritten extents, we can add a new *generic* test that tests for zeroed data extents rather than unwritten extents. All that we will need is a method of checking what behaviour the filesystem has and adding that to a _requires directive to ensure the correct generic fallocate tests are run... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
