Hi Vitaliy,
Thanks for the patch! Your patch is missing a Signed-Off-By footer.
Also, you note that numblocks gets passed to filefrag_fibmap(), so if
you're going to do this, and we fall back to using fibmap, you should
probably check to see if numblocks would overflow an unsigned long,
and if so, to give an error because fibmap ioctl only supports the use
of a ulong.
OK, I've just resubmitted it :)
In fact, the block count was reported incorrectly for files bigger than
0xffffffff bytes, not blocks, because filefrag does (numblocks *
fsinfo.f_bsize >> blk_shift), and this overflows when numblocks is
32-bit...
--
With best regards,
Vitaliy Filippov
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
