Re: [PATCH 08/10] debugfs: remove dead code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/7/14, 8:53 AM, Theodore Ts'o wrote:
> Addresses-Coverity-Id: #1138573
> 
> Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx>

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

FWIW, Darrick had already sent this as part of

"[PATCH 1/2] misc: fix resource leaks in e2fsprogs"

- but I suppose small targeted patches are better.

-Eric

> ---
>  debugfs/debugfs.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
> index 998af33..0e56ead 100644
> --- a/debugfs/debugfs.c
> +++ b/debugfs/debugfs.c
> @@ -289,8 +289,6 @@ void do_init_filesys(int argc, char **argv)
>  	if (err)
>  		return;
>  	ext2fs_blocks_count_set(&param, blocks);
> -	if (err)
> -		return;
>  	retval = ext2fs_initialize(argv[1], 0, &param,
>  				   unix_io_manager, &current_fs);
>  	if (retval) {
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux