current e2image cannot handle offset value as 0.
For example,
e2image -aro 0 /dev/sda7 ~/e2image7
will return usage()
but
e2image -aro 1 /dev/sda7 ~/e2image7
is fine.
Signed-off-by: "Jon Ernst" <jonernst07@xxxxxxxxx>
---
misc/e2image.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/misc/e2image.c b/misc/e2image.c
index 74515c8..af97d7a 100644
--- a/misc/e2image.c
+++ b/misc/e2image.c
@@ -1485,9 +1485,11 @@ int main (int argc, char ** argv)
break;
case 'o':
source_offset = strtoull(optarg, NULL, 0);
+ move_mode = 1;
break;
case 'O':
dest_offset = strtoull(optarg, NULL, 0);
+ move_mode = 1;
break;
case 'p':
show_progress = 1;
@@ -1498,10 +1500,7 @@ int main (int argc, char ** argv)
default:
usage();
}
- if (optind == argc - 1 &&
- (source_offset || dest_offset))
- move_mode = 1;
- else if (optind != argc - 2 )
+ if ((optind != argc - 2 ) && (move_mode))
usage();
if (all_data && !img_type) {
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
