On Fri, Dec 20, 2013 at 01:13:33PM +0800, Yongqiang Yang wrote: > From: Yongqiang Yang <xiaoqiangnk@xxxxxxxxx> > > can be reproduced by xfstests 62 with bigalloc and 128bit size inode. > > Signed-off-by: Yongqiang Yang <yangyongqiang01@xxxxxxxxx> > --- > fs/ext4/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 9115f28..1869fcf 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -145,7 +145,7 @@ static int ext4_meta_trans_blocks(struct inode > *inode, int lblocks, > static int ext4_inode_is_fast_symlink(struct inode *inode) > { > int ea_blocks = EXT4_I(inode)->i_file_acl ? > - (inode->i_sb->s_blocksize >> 9) : 0; > + EXT4_CLUSTER_SIZE(inode->i_sb) >> 9 : 0; Code looks good, but looks like it has an extra TAB here. Just a cosmetic thing; despite that, consider it Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx> -- Carlos -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html