On Fri, Dec 20, 2013 at 11:17:31AM -0700, Matthew Wilcox wrote: > On Thu, Dec 19, 2013 at 12:18:48PM -0500, Theodore Ts'o wrote: > > On Thu, Dec 19, 2013 at 10:12:02AM -0700, Matthew Wilcox wrote: > > > > > > ... I think it'll actually be ext4_get_block_fault, not _write, and it > > > will include code to zero the returned blocks if they're uninitialised. > > > > I assume what you mean here is if we see that the blocks are > > uninitialized, we don't need to read from the persistent memory at > > all; we can just map in a zeroed page, hopefully one from our stock of > > pre-zeroed pages. Yes? > > Maybe. We have a tension here between wanting to avoid unnecessary > writes to the media (as you say, wear is going to be important for some > media, if not all) and wanting to not fragment files (both for extent > tree compactness and so that we can use PMD or even PGD mappings if the > stars align). It'll be up to the filesystem whether it chooses to satisfy > the get_block request with something prezeroed, or something that aligns > nicely. Ideally, it'll be able to find a block of storage that does both! Yes, XFS with it's per-file extent size hints does that already. Like I've said previously - this is a solved problem and all we need is the IO completion callbacks to make sub-extent size IOs convert the allocated unwritten regions appropriately... > Actually, I now see a second way to read what you wrote. If you meant > "we can map in ZERO_PAGE or one of its analogs", then no. The amount > of cruft that optimisation added to the filemap_xip code is horrendous. > I don't think it's a particularly common workload (mmap a holey file, > read lots of zeroes out of it without ever writing to it), so I think > it's far better to allocate a page of storage and zero it. Happens far more often than you think in scientific calculations. Sparse matrices are extremely common, and it's a valid optimistion to walk then with mmap and have all the uninitialised vectors simply return zero without having storage space allocated. In this sort of situation, you really don't want to be allocating and zeroing persistent memory just because a terabyte sized sparse identity matrix was mmapped and read in it's entirity during a calculation.... Persistent memory needs to handle sparse files efficiently. I'd suggest that we already have very well tested mechanism to do that: the mapping tree on each inode. use the radix tree to index the space, mapping either a zero page into each hole index that is mapped read only, and replace it with an allocated, zeroed mapping at page_mkwrite() time. i.e. use the mapping radix tree to point at all the pages we've mapped from the backing device rather than just mapping an anonymous memory address from the backing device into userspace. That also opens the door for easily retrofitting buffered writes into persistent memory if we need them (e.g. mmap() of encrypted persistent memory). Once again, we don't need to re-invent the wheel because we already have one designed specifically for this purpose.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
