[PATCH] debugfs: silence build warning and remove incorrect error message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Commit fe56188b07 modified the code used to check the block number
argument to the command line -s switch, adding a call to com_err().
This causes a compile time warning because the third argument to
com_err() isn't a string.  Also, when the block number argument is
bad it outputs an incorrect error message - "Operation not permitted".

Fix these minor problems by removing the call to com_err().  Other
code provides enough error reporting information in this case.

Signed-off-by: Eric Whitney <enwlinux@xxxxxxxxx>
---
 debugfs/debugfs.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
index 6982ff6..095741f 100644
--- a/debugfs/debugfs.c
+++ b/debugfs/debugfs.c
@@ -2458,10 +2458,8 @@ int main(int argc, char **argv)
 			break;
 		case 's':
 			retval = strtoblk(argv[0], optarg, &superblock);
-			if (retval) {
-				com_err(argv[0], retval, 0, debug_prog_name);
+			if (retval)
 				return 1;
-			}
 			break;
 		case 'c':
 			catastrophic = 1;
-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux