On Wed, Dec 18, 2013 at 09:12:41PM -0700, Matthew Wilcox wrote: > On Wed, Dec 18, 2013 at 09:07:59PM -0500, Theodore Ts'o wrote: > > On Wed, Dec 18, 2013 at 07:27:49AM -0700, Matthew Wilcox wrote: > > > > > > I think there is a callback in xip_file_write(), and it's get_xip_mem(). > > > From what you're saying, it sounds like it's just not doing enough. > > > > The problem is that git_xip_mem() is called before we write to the > > memory, right? > > > > We need to convert the uninit extents to be marked as initialized in > > *after* the write has been sent to the storage medium. > > Now that I've spent the best part of a day looking at the ext4 code, I > still don't think there's a problem here. With the way the XIP code is > currently written (calling ext4_get_block with create=1), we won't get an > uninitialised extent in the caller. Instead, we'll get one that's been > zeroed (the zeroing is part of patch 3/3 and done only for xip files). You will with XFS. And you will when an application uses fallocate() to allocate the space before the write(2) call. So it's irrelevant what the write call does - the generic infrastructure needs to handle the fact that it can be writing into an unwritten region and be required to call a filesystem specific IO completion handler to deal with it. > As I understand it, when ext4 uses direct I/O, it can pass > ext4_get_block_write() as the get_block method, which uses the > magic EXT4_GET_BLOCKS_IO_CREATE_EXT flag to permit the allocation of > uninitialised extents. But the regular ext4_get_block cannot create > uninitialised extents (it can return them in the case of create=0, > and we handle that correctly as a hole). Stop thinking that ext4 is the entire world. XFS creates unwritten extents via the direct IO getblock callout when create=1 is set an dthe write lands in a hole. It then uses the IO completion callout ot convert them to written extents once the write IO is complete. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
