On Thu, Dec 12, 2013 at 08:07:20PM +0100, Andreas Gruenbacher wrote:
> Christoph,
>
> > +int
> > +posix_acl_chmod(struct inode *inode)
> > +{
> > + struct posix_acl *acl;
> > + int ret = 0;
> > +
> > + if (S_ISLNK(inode->i_mode) || !inode->i_op->set_acl)
> > + return -EOPNOTSUPP;
>
> Symlinks never have get_acl callbacks, so I would remove the S_ISLNK() check here.
Yeah, will simplify it. Same for the other places where we have both
checks.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
