On Tue 29-10-13 10:04:35, Christoph Hellwig wrote: > On Tue, Oct 29, 2013 at 03:46:49PM +0100, Jan Kara wrote: > > No, it isn't really recommended for ordinary SSDs. If you have one of > > those fancy PCIe attached SSDs, 'discard' option might be useful for you > > but for usual SATA attached ones it's usually a disaster. There you might > > be better off running 'fstrim' command once a week or something like that. > > While some early consumer SSDs were indeed pretty bad just by > theselves, and the lack of queue TRIM on most devices doesn't help, > these days the biggest blame is with Linux itself. Not only can't we > merge multiple requests into a single ranged TRIM, but we also execute > them all synchronously, meaning a constant stream of queue drains if > the discard option is used. > > Once we've fixed those issue we can start blaming those vendors that > have issues again, but until that has happened we'd better shut up.. OK, right. I've checked the spec and indeed the original TRIM specification already allows for several ranges in one trim command which we aren't able to use. I thought the multi-range thing was only a recent addition. Next time I'll be blaming our block layer then ;) Thanks for correction. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
