On 10/14/13 8:55 AM, Theodore Ts'o wrote: > On Tue, Jan 22, 2013 at 05:00:48PM -0700, Andreas Dilger wrote: >> From: Niu Yawei <niu@xxxxxxxxxxxxx> >> >> Update all superblock copies when disabling the quota feature. >> >> Added basic tests for the quota feature. >> >> Signed-off-by: Niu Yawei <niu@xxxxxxxxxxxxx> >> Signed-off-by: Andreas Dilger <adilger@xxxxxxxxxxxxx> > > Applied, thanks. This actually breaks things (or seems to, I haven't chased it all down; quota stuff is busted, anyway): # git clone git://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git # cd e2fsprogs # git checkout next # ./configure # make ... make[2]: Entering directory `/tmp/e2fsprogs/e2fsck' ... CC prof_err.c CC logfile.c CC sigcatcher.c make[2]: *** No rule to make target `../lib/libquota.a', needed by `e2fsck'. Stop. make[2]: Leaving directory `/tmp/e2fsprogs/e2fsck' make[1]: *** [all-progs-recursive] Error 1 make[1]: Leaving directory `/tmp/e2fsprogs' make: *** [all] Error 2 "make clean" doesn't remove lib/libquota.a (nor does git clean -f -d thanks to .gitignore (?)) so old builds pretend to be ok. Using QUOTA_CMT on lib requirements might work but it's hacky, it'd mean the LIBQUOTA stuff has to be last on the line, and if we ever have more than 1 configurable lib, then what? -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
