On Sat, Oct 12, 2013 at 04:31:17PM +0800, Zheng Liu wrote:
> On Sat, Oct 12, 2013 at 01:18:25AM -0700, Darrick J. Wong wrote:
> > On Sat, Oct 12, 2013 at 04:08:46PM +0800, Zheng Liu wrote:
> > > On Fri, Oct 11, 2013 at 05:27:18PM -0700, Darrick J. Wong wrote:
> > > [...]
> > > > > + */
> > > > > + if ((fs_param.s_feature_incompat & EXT4_FEATURE_INCOMPAT_INLINE_DATA) &&
> > > > > + !(fs_param.s_feature_compat & EXT2_FEATURE_COMPAT_EXT_ATTR)) {
> > > > > + com_err(program_name, 0,
> > > > > + _("Ext_attr feature not enabled, so inline_data "
> > > > > + "feature doesn't be specified"));
> > > >
> > > > "The inline_data feature requires the ext_attr feature." ?
> > >
> > > Ah, I have noticed that now we set xattr handler by default. So, yes,
> > > inline_data feature doesn't require the ext_attr feature.
> >
> > I think you /do/ still need this check, just in case someone tries to mkfs -O
> > ^ext_attr,inline_data. Defaults can be overridden.
>
> I have tested this ('mkfs -O ^ext_attr,inline_data') just a minute ago,
> and it seems that it works well. BTW, when we use setfattr(1) to set
> xattr in a ext4 file system without ext_attr feature, this feature will
> be enabled in ext4_xattr_update_super_block().
Oh good! My mistake, then. That teaches me to squint at my computer at 1:30
in the morning. :)
--D
>
> - Zheng
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
