On Mon, Oct 07, 2013 at 09:03:28AM -0400, Theodore Ts'o wrote: > On Thu, Oct 03, 2013 at 12:04:44PM -0700, Darrick J. Wong wrote: > > On Thu, Oct 03, 2013 at 06:53:38PM +0200, Lukáš Czerner wrote: > > > On Mon, 30 Sep 2013, Darrick J. Wong wrote: > > > > > > > Date: Mon, 30 Sep 2013 18:26:49 -0700 > > > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > To: tytso@xxxxxxx, darrick.wong@xxxxxxxxxx > > > > Cc: linux-ext4@xxxxxxxxxxxxxxx > > > > Subject: [PATCH 01/31] tune2fs: Don't convert block # to cluster # when > > > > clearing uninit_bg > > > > > > > > When we're constructing the initial block bitmap as part of removing the > > > > gdt_csum (i.e. uninit_bg) feature, we mustn't convert the block numbers to > > > > cluster numbers because ext2fs_mark_block_bitmap2() does this for us. > > > > > > I wonder if it's possible to use the old-style bitmap interface (the > > > one which does not understand 64-bit bitmaps). If so, then you also > > > need to fix ext2fs_mark_generic_bmap() (and others) so that we > > > convert blocks to clusters if needed. > > > > It's possible to do this (bad thing) by not specifying EXT2_FLAG_64BITS when > > calling ext2fs_openfs(); see patch 26 for a quick fix. > > Bigalloc requires the new-style bitmaps, so patch 26 is the right fix > for this. Any thoughts on patch #1? It fixes bugs in the recently-landed patch "tune2fs: zero inode table when removing checksums". --D > > - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
