On Mon, Oct 07, 2013 at 09:17:27AM -0400, Theodore Ts'o wrote: > On Mon, Sep 30, 2013 at 06:26:55PM -0700, Darrick J. Wong wrote: > > The ext2fs_link helper function link_proc does not check the value of ls->done, > > which means that if the function finds multiple empty spaces that will fit the > > new directory entry, it will create a directory entry in each of the spaces. > > Instead of doing that, check the done value and don't do anything more if we've > > already added the directory entry. > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Thanks, applied. > > One minor nit, which I'll generally fix myself when I have the chance: > > I generally like to fill comments at column 70, and in general, to try > to keep the summary line under 76 columns if possible, so that "git > log" doesn't wrap on 80 column screens. It's not always possible to > do the latter, but it's something I will try to do. Also, personally > prefer to use a lowercase to start the description since these > constraints generally mean the summary line can't be a complete > sentence. Ok. Assuming that you're reformatting the descriptions of the patches you're taking into your tree, I'll reformat the descriptions on the ones that don't make it in or require rework. --D > > - Ted > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
