On Mon, Sep 30, 2013 at 9:26 PM, Darrick J. Wong <darrick.wong@xxxxxxxxxx> wrote: > The ext2fs_link helper function link_proc does not check the value of ls->done, > which means that if the function finds multiple empty spaces that will fit the > new directory entry, it will create a directory entry in each of the spaces. > Instead of doing that, check the done value and don't do anything more if we've > already added the directory entry. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > lib/ext2fs/link.c | 3 +++ > 1 file changed, 3 insertions(+) > > > diff --git a/lib/ext2fs/link.c b/lib/ext2fs/link.c > index f715067..e3ff450 100644 > --- a/lib/ext2fs/link.c > +++ b/lib/ext2fs/link.c > @@ -43,6 +43,9 @@ static int link_proc(struct ext2_dir_entry *dirent, > int ret = 0; > int csum_size = 0; > > + if (ls->done) > + return 0; maybe "return ret;" here to keep consistency. > + > rec_len = EXT2_DIR_REC_LEN(ls->namelen); > > ls->err = ext2fs_get_rec_len(ls->fs, dirent, &curr_rec_len); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
