On Mon, Sep 30, 2013 at 01:29:09PM -0700, Andi Kleen wrote: > From: Andi Kleen <ak@xxxxxxxxxxxxxxx> > > The first loop in ext4_mb_init_cache can bail out when the end of > all groups is reached. Unfortunately the later loops did not > have that check and could access uninitialized buffer pointers > in bh[]. Add the end of group check everywhere. > > Cc: tytso@xxxxxxx > Cc: linux-ext4@xxxxxxxxxxxxxxx > Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx> > --- > Makefile | 6 +++--- > fs/ext4/mballoc.c | 6 +++++- > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/Makefile b/Makefile > index 8d0668f..be3ef83 100644 > --- a/Makefile > +++ b/Makefile > @@ -663,9 +663,9 @@ KBUILD_CFLAGS += $(call cc-option,-fconserve-stack) > KBUILD_ARFLAGS := $(call ar-option,D) > > # check for 'asm goto' > -ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC)), y) > - KBUILD_CFLAGS += -DCC_HAVE_ASM_GOTO > -endif > +#ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC)), y) > +# KBUILD_CFLAGS += -DCC_HAVE_ASM_GOTO > +#endif > > # Add user supplied CPPFLAGS, AFLAGS and CFLAGS as the last assignments > KBUILD_CPPFLAGS += $(KCPPFLAGS) What's this change all about, and why is it included in this patch? - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html