Re: [PATCH 2/2] ext4: use kobj_completion in ext4_sb_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 10, 2013 at 01:44:13PM -0400, Jeff Mahoney wrote:
> Now that we have the kobj_completion structure available, let's use it
> in ext4.
> 
> Note that we aggregate the del/put/wait_for_completion in one
> kobj_completion_del_and_wait call. Since the kobject isn't used for
> anything while the fs is shutting down and we wait until it's released
> before continuing anyway, this is safe.
> 
> Signed-off-by: Jeff Mahoney <jeffm@xxxxxxxx>

I don't have a huge objection to this, but given that it's not fixing
a bug, and it's not saving _that_ many lines of code, if you want to
run the first patch through Greg's tree (which is fine with me), I
might wait to merge this patch until 3.13, so it's not obvious that
it's worth dealing with the inter-tree dependency, since it
complicates testing on my end.

Does that sound reasonable?

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux