On Mon, Aug 12, 2013 at 03:39:04PM +0200, Jan Kara wrote: > When jbd2_journal_dirty_metadata() returns error, > __ext4_handle_dirty_metadata() stops the handle. However callers of this > function do not count with that fact and still happily used now freed > handle. This use after free can result in various issues but very likely > we oops soon. > > The motivation of adding __ext4_journal_stop() into > __ext4_handle_dirty_metadata() in commit 9ea7a0df seems to be only to > improve error reporting. So replace __ext4_journal_stop() with > ext4_journal_abort_handle() which was there before that commit and add > WARN_ON_ONCE() to dump stack to provide useful information. > > Reported-by: Sage Weil <sage@xxxxxxxxxxx> > Signed-off-by: Jan Kara <jack@xxxxxxx> Applied, thanks. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
