On Mon, Aug 05, 2013 at 10:34:52AM -0700, Darrick J. Wong wrote:
> On Fri, Aug 02, 2013 at 05:49:30PM +0800, Zheng Liu wrote:
> > From: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> >
> > We need to define some functions to operate extended attribute in order
> > to support inline data.
> >
> > Signed-off-by: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> > Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
> > ---
> > lib/ext2fs/ext2_err.et.in | 3 +
> > lib/ext2fs/ext2_ext_attr.h | 31 ++++++++
> > lib/ext2fs/ext2fs.h | 9 +++
> > lib/ext2fs/ext_attr.c | 186 ++++++++++++++++++++++++++++++++++++++++++++
> > 4 files changed, 229 insertions(+)
> >
> > diff --git a/lib/ext2fs/ext2_err.et.in b/lib/ext2fs/ext2_err.et.in
> > index d20c6b7..7e6d6e5 100644
> > --- a/lib/ext2fs/ext2_err.et.in
> > +++ b/lib/ext2fs/ext2_err.et.in
> > @@ -476,4 +476,7 @@ ec EXT2_ET_MMP_CSUM_INVALID,
> > ec EXT2_ET_FILE_EXISTS,
> > "Ext2 file already exists"
> >
> > +ec EXT2_ET_EXT_ATTR_CURRUPTED,
> > + "Extended attribute currupted"
>
> "corrupted".
Thanks for pointing it out. Fix it in next spin.
>
> (Or maybe shorten that to "corrupt"?)
I find the 'CORRUPT' in lib/ext2fs/ext2_err.et.in, and the result are as
below.
$ grep CORRUPT lib/ext2fs/ext2_err.et.in
ec EXT2_ET_DIR_CORRUPTED,
ec EXT2_ET_CORRUPT_SUPERBLOCK,
ec EXT2_ET_RESIZE_INODE_CORRUPT,
ec EXT2_ET_TDB_ERR_CORRUPT,
It seems that there is no any rule about this. I am wondering if we
need to rename _DIR_CORRUPTED to _DIR_CORRUPT. I am ok for using
_CORRUPT or _CORRUPTED.
Regards,
- Zheng
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
