On Tue 30-07-13 07:44:25, Zheng Liu wrote: > Sorry for my bad description. As Jan said, this patch doesn't address > any issue. It just makes the code clearly. After applied this patch, > I still get the warning messages from ext4_da_release_space running > xfstests #74 when blocksize = 1k. Interesting. I never noticed those but now I see them as well. Dave Jones also reported this problem (although he didn't mention 1KB blocksize). I'll try to have a look into it. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html