On Mon 29-07-13 12:21:51, Ted Tso wrote: > On Fri, Jul 26, 2013 at 07:42:06AM +0800, Zheng Liu wrote: > > From: Jan Kara <jack@xxxxxxx> > > > > Now in ext4_da_page_release_reservation() we remove the entry from es > > tree if to_release != 0. But there are two issues. One is that it is > > wrong when blocksize != pagesize, > > The commit description says that this is wrong, but I don't see > anything in the patch which addresses this. And could you state what > the impact is of this wrongness? Well, this wrongness actually shouldn't have any real impact - for blocksize < pagesize the extent tree isn't used while truncate_pagecache() is running and ext4_truncate() then removes the whole truncated range from the tree again which hides any problems in ext4_da_page_release_reservation(). When bigalloc is used, we use the extent tree during truncate_pagecache() but to_release is always == 1 and thus the problem doesn't exist. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
