On 06/14/2013 10:11 AM, Zheng Liu wrote: > On Fri, Jun 14, 2013 at 08:57:44AM -0700, Dave Hansen wrote: >> > On 06/14/2013 07:09 AM, Zheng Liu wrote: >>> > > - INIT_LIST_HEAD(&scanned); >>> > > - >>> > > spin_lock(&sbi->s_es_lru_lock); >>> > > + list_sort(NULL, &sbi->s_es_lru, ext4_inode_touch_time_cmp); >>> > > list_for_each_safe(cur, tmp, &sbi->s_es_lru) { >> > >> > How long can this list get? I have the feeling this might get a bit >> > painful, especially on a NUMA machine. > I guess that you worry about the time of sorting a lru list, right? Yeah, just worried about the amount of time it takes to examine (and possibly write to) every item on the list. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html