On Tue, 28 May 2013 23:51:12 +0200, Jan Kara <jack@xxxxxxx> wrote:
> On Tue 28-05-13 13:18:57, Dmitry Monakhov wrote:
> > Inode's data or non journaled quota may be written w/o jounral so we _must_
> > send a barrier at the end of ext4_sync_fs. But it can be skipped if journal
> > commit will do it for us.
> >
> > Also fix data integrity for nojournal mode.
> > changes from v1:
> > skip barrier for async mode
> One comment below:
>
> > diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> > index c9e1ab6..ed974fd 100644
> > --- a/include/linux/jbd2.h
> > +++ b/include/linux/jbd2.h
> > @@ -1319,6 +1319,21 @@ static inline u32 jbd2_chksum(journal_t *journal, u32 crc,
> > return *(u32 *)desc.ctx;
> > }
> >
> > +/* Return most recent uncommitted transaction */
> > +static inline tid_t jbd2_get_latest_transaction(journal_t *journal)
> > +{
> > + tid_t tid;
> > +
> > + read_lock(&journal->j_state_lock);
> > + tid = journal->j_commit_request;
> > + if (journal->j_running_transaction) {
> > + tid = journal->j_running_transaction->t_tid;
> > + } else if (!journal->j_commit_sequence)
> I would expect here journal->j_committing_transaction and then
> journal->j_commit_request below. And you can use j_commit_sequence as an
> initial 'tid' value...
I have to admit that my code is not correct because function should
return 'most recent uncommitted transaction', but I do not get your
idea. journal->j_commit_request >= jorunal->j_committing_transaction
and journal->j_commit_request >= journal->j_commit_sequence
So it is reasonable to define function like follows:
static inline tid_t jbd2_get_latest_transaction(journal_t journal)
{
tid_t tid;
read_lock(&journal->j_state_lock);
tid = journal->j_commit_request;
if (journal->j_running_transaction)
tid = journal->j_running_transaction->t_tid;
read_unlock(&journal->j_state_lock);
return tid;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
