On 5/30/13 7:45 AM, Jan Kara wrote:
> The intention of tests 08 and 09 in test generic/285 is to sync the
> whole file before checking for data and holes. However the helper is
> called with nbytes argument set to 0 which results in not syncing
> anything. Set nbytes properly.
Hm, are you sure? (Is the man page wrong, or is the sync_file_range
implementation wrong?)
DESCRIPTION
sync_file_range() permits fine control when synchronizing the
open file referred to by the file descriptor fd with disk.
offset is the starting byte of the file range to be synchro-
nized. nbytes specifies the length of the range to be synchro-
nized, in bytes; if nbytes is zero, then all bytes from offset
through to the end of file are synchronized.
-Eric
> Signed-off-by: Jan Kara <jack@xxxxxxx>
> ---
> src/seek_sanity_test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
> index eec6903..7d5868b 100644
> --- a/src/seek_sanity_test.c
> +++ b/src/seek_sanity_test.c
> @@ -229,7 +229,7 @@ static int test09(int fd, int testnum)
> * Sync out dirty pages from bufsz * 100, this will convert
> * the dirty page to writeback.
> */
> - ret = do_sync_dirty_pages(fd, bufsz * 100, 0);
> + ret = do_sync_dirty_pages(fd, bufsz * 100, filsz);
> if (ret)
> goto out;
>
> @@ -269,7 +269,7 @@ static int test08(int fd, int testnum)
> goto out;
>
> /* Sync out all file */
> - ret = do_sync_dirty_pages(fd, 0, 0);
> + ret = do_sync_dirty_pages(fd, 0, filsz);
> if (ret)
> goto out;
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
