On 2013-05-10, at 17:38, "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> wrote: > static void jbd2_block_tag_csum_set(journal_t *j, journal_block_tag_t *tag, > { > > + tag->t_checksum = cpu_to_be16(csum32); > } It wouldn't be a terrible idea to add a comment in these spots, since it is a bit non-obvious to use cpu_to_be16() on a 32-bit variable. Cheers, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html